Skip to content

fix: preserve state in DistinctMedianAccumulator::evaluate() for window frame queries#19887

Merged
Jefffrey merged 1 commit intoapache:mainfrom
kumarUjjawal:fix/retract_batch_accumulator_distinct_median
Jan 21, 2026
Merged

fix: preserve state in DistinctMedianAccumulator::evaluate() for window frame queries#19887
Jefffrey merged 1 commit intoapache:mainfrom
kumarUjjawal:fix/retract_batch_accumulator_distinct_median

Conversation

@kumarUjjawal
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

The DistinctMedianAccumulator::evaluate() method was using std::mem::take() which consumed the internal state, causing subsequent calls to return incorrect results. This was the last remaining item from #19612

What changes are included in this PR?

  1. Changed DistinctMedianAccumulator::evaluate() to use .iter() instead of std::mem::take() to preserve internal state across multiple calls
  2. Added sqllogictest case for distinct median with window frames

Are these changes tested?

Yes, added a sqllogictest

Are there any user-facing changes?

No

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Jan 19, 2026
@Jefffrey Jefffrey added this pull request to the merge queue Jan 21, 2026
Merged via the queue into apache:main with commit 6b1a1cb Jan 21, 2026
28 checks passed
@Jefffrey
Copy link
Copy Markdown
Contributor

Thanks @kumarUjjawal

de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
…ow frame queries (apache#19887)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes apache#19612.

## Rationale for this change

The `DistinctMedianAccumulator::evaluate()` method was using
`std::mem::take()` which consumed the internal state, causing subsequent
calls to return incorrect results. This was the last remaining item from
apache#19612

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

1. Changed `DistinctMedianAccumulator::evaluate()` to use `.iter()`
instead of `std::mem::take()` to preserve internal state across multiple
calls
2. Added sqllogictest case for distinct median with window frames

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

Yes, added a sqllogictest

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

No

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accumulators which don't implement retract_batch can still exhibit buggy behaviour

2 participants